lkml.org 
[lkml]   [2018]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v12 11/22] selftests/vm: pkey register should match shadow pkey
    Date
    expected_pkey_fault() is comparing the contents of pkey
    register with 0. This may not be true all the time. There
    could be bits set by default by the architecture
    which can never be changed. Hence compare the value against
    shadow pkey register, which is supposed to track the bits
    accurately all throughout

    cc: Dave Hansen <dave.hansen@intel.com>
    cc: Florian Weimer <fweimer@redhat.com>
    Signed-off-by: Ram Pai <linuxram@us.ibm.com>
    ---
    tools/testing/selftests/vm/protection_keys.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c
    index 254b66d..6054093 100644
    --- a/tools/testing/selftests/vm/protection_keys.c
    +++ b/tools/testing/selftests/vm/protection_keys.c
    @@ -926,10 +926,10 @@ void expected_pkey_fault(int pkey)
    pkey_assert(last_pkey_faults + 1 == pkey_faults);
    pkey_assert(last_si_pkey == pkey);
    /*
    - * The signal handler shold have cleared out PKEY register to let the
    + * The signal handler shold have cleared out pkey-register to let the
    * test program continue. We now have to restore it.
    */
    - if (__rdpkey_reg() != 0)
    + if (__rdpkey_reg() != shadow_pkey_reg)
    pkey_assert(0);

    __wrpkey_reg(shadow_pkey_reg);
    --
    1.7.1
    \
     
     \ /
      Last update: 2018-02-22 03:00    [W:3.049 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site