Messages in this thread | | | From | Kees Cook <> | Date | Wed, 21 Feb 2018 16:27:12 -0800 | Subject | Re: RANDSTRUCT structs need linux/compiler_types.h (Was: [nfsd4] potentially hardware breaking regression in 4.14-rc and 4.13.11) |
| |
On Wed, Feb 21, 2018 at 4:23 PM, Kees Cook <keescook@chromium.org> wrote: > On Wed, Feb 21, 2018 at 4:22 PM, Linus Torvalds > <torvalds@linux-foundation.org> wrote: >> On Wed, Feb 21, 2018 at 4:12 PM, Kees Cook <keescook@chromium.org> wrote: >>> >>> Do you want me to send the patch for this, or do you already have it >>> prepared? >> >> I'd rather get something explicitly tested. I tried my earlier patch >> with "make allmodconfig" (and a fix to nfsd to make it compile), but >> now I'm back to testing hjl's gas updates so it would be better to get >> a tested commit with a good commit message. >> >>> The body-fields I had prepared for the nfs were: >>> >>> Reported-by: Patrick McLean <chutzpah@gentoo.org> >>> Reported-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> >> >> Oh, I think Maciej needs to get more than a "Reported-by:". This was a >> really subtle thing that we didn't figure out in the original thread, >> so give him a gold star in the form of "Root-caused-by:" or something. > > Oops, I just sent this out. I will adjust a re-send. I couldn't find a > documented field name for this...
With the "root-cause" hint, I see we have used:
2 Root-cause-analysis-by: 2 Root-caused-by: 1 Root-cause-found-by:
I'll go with your "Root-caused-by" to tip the scale. :)
-Kees
-- Kees Cook Pixel Security
| |