lkml.org 
[lkml]   [2018]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 075/100] rtc: zynqmp: stop validating rtc_time in .read_time
    Date
    rtc_time64_to_tm never generates an invalid tm. It is not necessary to
    validate it. Also, the RTC core is always calling rtc_valid_tm after the
    read_time callback.

    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    ---
    drivers/rtc/rtc-zynqmp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c
    index da18a8ae3c1d..fba994dc31eb 100644
    --- a/drivers/rtc/rtc-zynqmp.c
    +++ b/drivers/rtc/rtc-zynqmp.c
    @@ -122,7 +122,7 @@ static int xlnx_rtc_read_time(struct device *dev, struct rtc_time *tm)
    rtc_time64_to_tm(read_time, tm);
    }

    - return rtc_valid_tm(tm);
    + return 0;
    }

    static int xlnx_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
    --
    2.16.1
    \
     
     \ /
      Last update: 2018-02-21 22:07    [W:6.501 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site