lkml.org 
[lkml]   [2018]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 087/100] rtc: rx8581: remove useless message
    Date
    It is not necessary to print a message when the time is invalid as
    userspace will already get an error (and an optional dev_dbg message).

    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    ---
    drivers/rtc/rtc-rx8581.c | 6 +-----
    1 file changed, 1 insertion(+), 5 deletions(-)

    diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c
    index 9998d7937688..32caadf912ca 100644
    --- a/drivers/rtc/rtc-rx8581.c
    +++ b/drivers/rtc/rtc-rx8581.c
    @@ -164,11 +164,7 @@ static int rx8581_get_datetime(struct i2c_client *client, struct rtc_time *tm)
    tm->tm_sec, tm->tm_min, tm->tm_hour,
    tm->tm_mday, tm->tm_mon, tm->tm_year, tm->tm_wday);

    - err = rtc_valid_tm(tm);
    - if (err < 0)
    - dev_err(&client->dev, "retrieved date/time is not valid.\n");
    -
    - return err;
    + return 0;
    }

    static int rx8581_set_datetime(struct i2c_client *client, struct rtc_time *tm)
    --
    2.16.1
    \
     
     \ /
      Last update: 2018-02-21 22:04    [W:2.258 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site