lkml.org 
[lkml]   [2018]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 094/100] rtc: rs5c372: remove useless message
    Date
    It is not necessary to print a message when the time is invalid as
    userspace will already get an error (and an optional dev_dbg message).

    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    ---
    drivers/rtc/rtc-rs5c372.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c
    index d4eff8d7131f..37aa78fd2c4d 100644
    --- a/drivers/rtc/rtc-rs5c372.c
    +++ b/drivers/rtc/rtc-rs5c372.c
    @@ -581,7 +581,6 @@ static int rs5c372_probe(struct i2c_client *client,
    int err = 0;
    int smbus_mode = 0;
    struct rs5c372 *rs5c372;
    - struct rtc_time tm;

    dev_dbg(&client->dev, "%s\n", __func__);

    @@ -662,9 +661,6 @@ static int rs5c372_probe(struct i2c_client *client,
    goto exit;
    }

    - if (rs5c372_get_datetime(client, &tm) < 0)
    - dev_warn(&client->dev, "clock needs to be set\n");
    -
    dev_info(&client->dev, "%s found, %s\n",
    ({ char *s; switch (rs5c372->type) {
    case rtc_r2025sd: s = "r2025sd"; break;
    --
    2.16.1
    \
     
     \ /
      Last update: 2018-02-21 22:03    [W:4.044 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site