Messages in this thread | | | Subject | Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs | From | Jae Hyun Yoo <> | Date | Wed, 21 Feb 2018 12:35:35 -0800 |
| |
On 2/21/2018 9:13 AM, Andrew Lunn wrote: > On Wed, Feb 21, 2018 at 08:16:00AM -0800, Jae Hyun Yoo wrote: >> This commit adds a dt-bindings document of PECI adapter driver for Aspeed >> AST24xx/25xx SoCs. > > Hi Jae > > It would be good to separate this into two. One binding document for a > generic adaptor, with a generic PECI bus, and generic client > devices. List all the properties you expect at the generic level. > > Then have an aspeed specific binding for those properties which are > specific to the Aspeed adaptor. >
That makes sense. I'll add generic PECI bus/adapter/client and Aspeed specific documents as separated.
> Andrew > >
Thanks again for sharing your time to review it. I really appreciate it.
BR, Jae
| |