Messages in this thread | | | Subject | Re: [PATCH 5/6] powerpc: Implement DISCONTIGMEM and allow selection on PPC32 | From | christophe leroy <> | Date | Wed, 21 Feb 2018 18:53:43 +0100 |
| |
Le 21/02/2018 à 17:08, Jonathan Neuschäfer a écrit : > On Wed, Feb 21, 2018 at 07:46:28AM +0800, kbuild test robot wrote: > [...] >>>> include/linux/mmzone.h:1239:19: error: conflicting types for 'pfn_valid' >> static inline int pfn_valid(unsigned long pfn) >> ^~~~~~~~~ >> In file included from include/linux/mmzone.h:912:0, >> from include/linux/gfp.h:6, >> from include/linux/mm.h:10, >> from include/linux/mman.h:5, >> from arch/powerpc/kernel/asm-offsets.c:22: >> arch/powerpc/include/asm/mmzone.h:40:19: note: previous definition of 'pfn_valid' was here >> static inline int pfn_valid(int pfn) >> ^~~~~~~~~ >> make[2]: *** [arch/powerpc/kernel/asm-offsets.s] Error 1 >> make[2]: Target '__build' not remade because of errors. >> make[1]: *** [prepare0] Error 2 >> make[1]: Target 'prepare' not remade because of errors. >> make: *** [sub-make] Error 2 > > Oops, I'll fix this in the next version (and compile-test on ppc64...). > > Weirdly enough, x86-32 and parisc define pfn_valid with an int > parameter, too (both of them since the Beginning Of Time, aka. > v2.6.12-rc2). >
Behind the fact that the pfn type is different, my understanding is that you have to define CONFIG_HAVE_ARCH_PFN_VALID in the Kconfig in order to avoid it being included in include/linux/mmzone.h
Christophe
--- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus
| |