lkml.org 
[lkml]   [2018]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 11/23] kconfig: add 'shell-stdout' function
    On Tue, Feb 20, 2018 at 8:59 PM, Masahiro Yamada
    <yamada.masahiro@socionext.com> wrote:
    >
    > IMO, I prefer to use different names for different purpose.
    > So, 'stdout' and 'success' look good to me.
    >
    > BTW, I noticed just one built-in function is enough
    > because 'success' can be derived from 'stdout'.
    >
    > So, my plan is, implement $(shell ...) as a built-in function.
    > This returns the stdout from the command.
    >
    > Then, implement 'success' as a textual shorthand
    > by using macro, like this:
    >
    > macro success $(shell ($(1) && echo y) || echo n)

    I like it. This is nice and clean, and seems to be very generic. I see
    no issues with this approach.

    Linus

    \
     
     \ /
      Last update: 2018-02-21 18:03    [W:4.795 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site