lkml.org 
[lkml]   [2018]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 11/15] gpio: rcar: Add R-Car M3-N compatible string
    Hi Geert,

    On Wed, Feb 14, 2018 at 03:05:05PM +0100, Geert Uytterhoeven wrote:
    > On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi
    > <jacopo+renesas@jmondi.org> wrote:
    > > Add compatible string for R-Car M3-N (r8a77965) in gpio-rcar.
    > >
    > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
    >
    > > --- a/drivers/gpio/gpio-rcar.c
    > > +++ b/drivers/gpio/gpio-rcar.c
    > > @@ -360,6 +360,10 @@ static const struct of_device_id gpio_rcar_of_table[] = {
    > > /* Gen3 GPIO is identical to Gen2. */
    > > .data = &gpio_rcar_info_gen2,
    > > }, {
    > > + .compatible = "renesas,gpio-r8a77965",
    > > + /* Gen3 GPIO is identical to Gen2. */
    > > + .data = &gpio_rcar_info_gen2,
    > > + }, {
    >
    > This part is not needed, as the driver already matches agains the generic
    > "renesas,rcar-gen3-gpio".

    Just to point out that the compatible string is there for M3-W and H3.
    Anyway, if that's not good practice to add per-SoC strings here, I'll
    drop this bit.

    Thanks
    j

    >
    > > .compatible = "renesas,rcar-gen1-gpio",
    > > .data = &gpio_rcar_info_gen1,
    > > }, {
    >
    > With the above fixed:
    > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    >
    > Gr{oetje,eeting}s,
    >
    > Geert
    >
    > --
    > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
    >
    > In personal conversations with technical people, I call myself a hacker. But
    > when I'm talking to journalists I just say "programmer" or something like that.
    > -- Linus Torvalds

    \
     
     \ /
      Last update: 2018-02-20 14:36    [W:4.298 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site