Messages in this thread | | | Subject | Re: [PATCH v6 4/5] KVM: VMX: Allow direct access to MSR_IA32_SPEC_CTRL | From | David Woodhouse <> | Date | Fri, 02 Feb 2018 18:05:54 +0000 |
| |
On Fri, 2018-02-02 at 12:53 -0500, Konrad Rzeszutek Wilk wrote: > .snip.. > > > > @@ -1913,6 +1914,29 @@ static void update_exception_bitmap(struct > > kvm_vcpu *vcpu) > > } > > > > /* > > + * Check if MSR is intercepted for currently loaded MSR bitmap. > > + */ > > +static bool msr_write_intercepted(struct kvm_vcpu *vcpu, u32 msr) > > +{ > > + unsigned long *msr_bitmap; > > + int f = sizeof(unsigned long); > > unsigned int
$ grep -n 'f = sizeof' vmx.c 1934: int f = sizeof(unsigned long); 5013: int f = sizeof(unsigned long); 5048: int f = sizeof(unsigned long); 5097: int f = sizeof(unsigned long);
It sucks enough that we're doing this stuff repeatedly, and it's a prime candidate for cleaning up, but I wasn't going to send Karim off to bikeshed that today. Let's at least keep it consistent. [unhandled content-type:application/x-pkcs7-signature] | |