lkml.org 
[lkml]   [2018]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net 2/4] net/8390: Fix msg_enable patch snafu
On Mon, 19 Feb 2018, David Miller wrote:

> From: Finn Thain <fthain@telegraphics.com.au>
> Date: Sun, 18 Feb 2018 21:39:17 -0500 (EST)
>
> > The lib8390 module parameter 'msg_enable' doesn't do anything useful:
> > it causes an ancient version string to be logged.
>
> Since you are removing the last reference to this 'version' string
> you should remove it as well.
>
> I'm surprised the compiler doesn't warn about this.
>

I compile-tested every 8390 module and I didn't come across any compiler
bugs.

Please take another look. I think you'll find that lib8390.c is always
#included by a module which does define that symbol.

Thanks.

--

\
 
 \ /
  Last update: 2018-02-19 23:02    [W:0.060 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site