lkml.org 
[lkml]   [2018]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE
Hi Lina,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc1 next-20180216]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Lina-Iyer/drivers-qcom-add-RPMH-communication-support/20180218-075659
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm

All error/warnings (new ones prefixed by >>):

In file included from include/trace/define_trace.h:96:0,
from drivers/soc/qcom/trace-rpmh.h:89,
from drivers/soc/qcom/rpmh-rsc.c:28:
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:22:26: error: expected ':', ',', ';', '}' or '__attribute__' before '->' token
__field(const char *, d->name)
^
include/trace/trace_events.h:114:3: note: in definition of macro 'DECLARE_EVENT_CLASS'
tstruct \
^~~~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:21:2: note: in expansion of macro 'TP_STRUCT__entry'
TP_STRUCT__entry(
^~~~~~~~~~~~~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:22:3: note: in expansion of macro '__field'
__field(const char *, d->name)
^~~~~~~
include/trace/../../drivers/soc/qcom/trace-rpmh.h:57:25: error: expected ':', ',', ';', '}' or '__attribute__' before '->' token
__field(const char*, d->name)
^
include/trace/trace_events.h:114:3: note: in definition of macro 'DECLARE_EVENT_CLASS'
tstruct \
^~~~~~~
include/trace/trace_events.h:77:9: note: in expansion of macro 'PARAMS'
PARAMS(tstruct), \
^~~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:50:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(rpmh_send_msg,
^~~~~~~~~~~
include/trace/../../drivers/soc/qcom/trace-rpmh.h:56:2: note: in expansion of macro 'TP_STRUCT__entry'
TP_STRUCT__entry(
^~~~~~~~~~~~~~~~
include/trace/../../drivers/soc/qcom/trace-rpmh.h:57:3: note: in expansion of macro '__field'
__field(const char*, d->name)
^~~~~~~
In file included from include/trace/define_trace.h:96:0,
from drivers/soc/qcom/trace-rpmh.h:89,
from drivers/soc/qcom/rpmh-rsc.c:28:
include/trace/../../drivers/soc/qcom/trace-rpmh.h: In function 'trace_raw_output_rpmh_notify':
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:36:11: error: 'struct trace_event_raw_rpmh_notify' has no member named 'name'
__entry->name, __entry->m, __entry->addr, __entry->errno)
^
include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:35:2: note: in expansion of macro 'TP_printk'
TP_printk("%s: ack: tcs-m:%d addr: 0x%08x errno: %d",
^~~~~~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:36:26: error: 'struct trace_event_raw_rpmh_notify' has no member named 'm'
__entry->name, __entry->m, __entry->addr, __entry->errno)
^
include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:35:2: note: in expansion of macro 'TP_printk'
TP_printk("%s: ack: tcs-m:%d addr: 0x%08x errno: %d",
^~~~~~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:36:38: error: 'struct trace_event_raw_rpmh_notify' has no member named 'addr'
__entry->name, __entry->m, __entry->addr, __entry->errno)
^
include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:35:2: note: in expansion of macro 'TP_printk'
TP_printk("%s: ack: tcs-m:%d addr: 0x%08x errno: %d",
^~~~~~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:36:53: error: 'struct trace_event_raw_rpmh_notify' has no member named 'errno'
__entry->name, __entry->m, __entry->addr, __entry->errno)
^
include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:35:2: note: in expansion of macro 'TP_printk'
TP_printk("%s: ack: tcs-m:%d addr: 0x%08x errno: %d",
^~~~~~~~~
include/trace/../../drivers/soc/qcom/trace-rpmh.h: In function 'trace_raw_output_rpmh_send_msg':
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:77:11: error: 'struct trace_event_raw_rpmh_send_msg' has no member named 'name'
__entry->name, __entry->m, __entry->n, __entry->hdr,
^
include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^~~~~
include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS'
PARAMS(print)); \
^~~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:50:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(rpmh_send_msg,
^~~~~~~~~~~
include/trace/../../drivers/soc/qcom/trace-rpmh.h:76:2: note: in expansion of macro 'TP_printk'
TP_printk("%s: send-msg: tcs(m): %d cmd(n): %d msgid: 0x%08x addr: 0x%08x data: 0x%08x complete: %d",
^~~~~~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:77:26: error: 'struct trace_event_raw_rpmh_send_msg' has no member named 'm'
__entry->name, __entry->m, __entry->n, __entry->hdr,
^
include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^~~~~
include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS'
PARAMS(print)); \
^~~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:50:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(rpmh_send_msg,
^~~~~~~~~~~
include/trace/../../drivers/soc/qcom/trace-rpmh.h:76:2: note: in expansion of macro 'TP_printk'
TP_printk("%s: send-msg: tcs(m): %d cmd(n): %d msgid: 0x%08x addr: 0x%08x data: 0x%08x complete: %d",
^~~~~~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:77:38: error: 'struct trace_event_raw_rpmh_send_msg' has no member named 'n'
__entry->name, __entry->m, __entry->n, __entry->hdr,
^
include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^~~~~
include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS'
PARAMS(print)); \
^~~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:50:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(rpmh_send_msg,
^~~~~~~~~~~
include/trace/../../drivers/soc/qcom/trace-rpmh.h:76:2: note: in expansion of macro 'TP_printk'
TP_printk("%s: send-msg: tcs(m): %d cmd(n): %d msgid: 0x%08x addr: 0x%08x data: 0x%08x complete: %d",
^~~~~~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:77:50: error: 'struct trace_event_raw_rpmh_send_msg' has no member named 'hdr'
__entry->name, __entry->m, __entry->n, __entry->hdr,
^
include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^~~~~
include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS'
PARAMS(print)); \
^~~~~~
>> include/trace/../../drivers/soc/qcom/trace-rpmh.h:50:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(rpmh_send_msg,
^~~~~~~~~~~
include/trace/../../drivers/soc/qcom/trace-rpmh.h:76:2: note: in expansion of macro 'TP_printk'
TP_printk("%s: send-msg: tcs(m): %d cmd(n): %d msgid: 0x%08x addr: 0x%08x data: 0x%08x complete: %d",
^~~~~~~~~

vim +22 include/trace/../../drivers/soc/qcom/trace-rpmh.h

16
17 TP_PROTO(struct rsc_drv *d, struct tcs_response *r),
18
19 TP_ARGS(d, r),
20
> 21 TP_STRUCT__entry(
> 22 __field(const char *, d->name)
23 __field(int, m)
24 __field(u32, addr)
25 __field(int, errno)
26 ),
27
> 28 TP_fast_assign(
> 29 __entry->name = d->name;
30 __entry->m = r->m;
31 __entry->addr = r->msg->payload[0].addr;
32 __entry->errno = r->err;
33 ),
34
> 35 TP_printk("%s: ack: tcs-m:%d addr: 0x%08x errno: %d",
> 36 __entry->name, __entry->m, __entry->addr, __entry->errno)
37 );
38
39 DEFINE_EVENT(rpmh_notify, rpmh_notify_irq,
40 TP_PROTO(struct rsc_drv *d, struct tcs_response *r),
41 TP_ARGS(d, r)
42 );
43
44 DEFINE_EVENT(rpmh_notify, rpmh_notify_tx_done,
45 TP_PROTO(struct rsc_drv *d, struct tcs_response *r),
46 TP_ARGS(d, r)
47 );
48
49
> 50 TRACE_EVENT(rpmh_send_msg,
51
52 TP_PROTO(struct rsc_drv *d, int m, int n, u32 h, struct tcs_cmd *c),
53
54 TP_ARGS(d, m, n, h, c),
55
56 TP_STRUCT__entry(
> 57 __field(const char*, d->name)
58 __field(int, m)
59 __field(int, n)
60 __field(u32, hdr)
61 __field(u32, addr)
62 __field(u32, data)
63 __field(bool, complete)
64 ),
65
66 TP_fast_assign(
> 67 __entry->name = s;
68 __entry->m = m;
69 __entry->n = n;
70 __entry->hdr = h;
71 __entry->addr = c->addr;
72 __entry->data = c->data;
73 __entry->complete = c->complete;
74 ),
75
76 TP_printk("%s: send-msg: tcs(m): %d cmd(n): %d msgid: 0x%08x addr: 0x%08x data: 0x%08x complete: %d",
> 77 __entry->name, __entry->m, __entry->n, __entry->hdr,
> 78 __entry->addr, __entry->data, __entry->complete)
79 );
80

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2018-02-18 12:28    [W:0.187 / U:2.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site