lkml.org 
[lkml]   [2018]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 8/9] lib/vsprintf: Remove useless NULL checks
    Date
    The pointer can't be NULL since it's first what has been done in the
    pointer().

    Remove useless checks.

    Note we leave check for !CONFIG_HAVE_CLK to make compiler
    to optimize code away when possible.

    Cc: Petr Mladek <pmladek@suse.com>
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    lib/vsprintf.c | 13 +------------
    1 file changed, 1 insertion(+), 12 deletions(-)

    diff --git a/lib/vsprintf.c b/lib/vsprintf.c
    index 97be2d07297a..a49da00b79e7 100644
    --- a/lib/vsprintf.c
    +++ b/lib/vsprintf.c
    @@ -819,10 +819,6 @@ char *hex_string(char *buf, char *end, u8 *addr, struct printf_spec spec,
    /* nothing to print */
    return buf;

    - if (ZERO_OR_NULL_PTR(addr))
    - /* NULL pointer */
    - return string(buf, end, NULL, spec);
    -
    switch (fmt[1]) {
    case 'C':
    separator = ':';
    @@ -1258,10 +1254,6 @@ char *escaped_string(char *buf, char *end, u8 *addr, struct printf_spec spec,
    if (spec.field_width == 0)
    return buf; /* nothing to print */

    - if (ZERO_OR_NULL_PTR(addr))
    - return string(buf, end, NULL, spec); /* NULL pointer */
    -
    -
    do {
    switch (fmt[count++]) {
    case 'a':
    @@ -1455,7 +1447,7 @@ static noinline_for_stack
    char *clock(char *buf, char *end, struct clk *clk, struct printf_spec spec,
    const char *fmt)
    {
    - if (!IS_ENABLED(CONFIG_HAVE_CLK) || !clk)
    + if (!IS_ENABLED(CONFIG_HAVE_CLK))
    return string(buf, end, NULL, spec);

    switch (fmt[1]) {
    @@ -1580,9 +1572,6 @@ char *device_node_string(char *buf, char *end, struct device_node *dn,
    if (!IS_ENABLED(CONFIG_OF))
    return string(buf, end, "(!OF)", spec);

    - if ((unsigned long)dn < PAGE_SIZE)
    - return string(buf, end, "(null)", spec);
    -
    /* simple case without anything any more format specifiers */
    fmt++;
    if (fmt[0] == '\0' || strcspn(fmt,"fnpPFcC") > 0)
    --
    2.15.1
    \
     
     \ /
      Last update: 2018-02-16 22:07    [W:3.155 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site