Messages in this thread | | | Subject | Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver | From | Daniel Lezcano <> | Date | Fri, 16 Feb 2018 18:39:35 +0100 |
| |
Hi Viresh,
sorry for the late reply.
On 09/02/2018 10:41, Viresh Kumar wrote: > On 07-02-18, 11:34, Daniel Lezcano wrote: >> On 07/02/2018 10:12, Viresh Kumar wrote: >>> What about cpuidle_cooling_unregister() ? >> >> The unregister function is not needed because cpuidle can't be unloaded. >> The cpuidle cooling device is registered after the cpuidle successfully >> initialized itself, there is no error path. > > Okay, then there are two more things here. > > First, you don't need a kref in your patch and simple counter should > be used instead, as kref is obviously more heavy to be used for the > single error path here.
I prefer to keep the kref for its API.
And I disagree about the heavy aspect :)
struct kref { refcount_t refcount; };
> Secondly, what about CPU hotplug ? For example, the cpu-freq cooling > device gets removed currently if all CPUs of a cluster are > hotplugged-out. But with your code, even if the CPUs are gone, their > cpu-idle cooling device will stay.
Yes and it will continue to compute the state, so if new CPUs are inserted the cooling device automatically uses the cooling state. I don't see a problem with that.
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |