lkml.org 
[lkml]   [2018]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv4 2/4] ASoC: codec: cpcap: new codec
On Wed, Feb 14, 2018 at 11:07:39PM +0100, Sebastian Reichel wrote:

> +config SND_SOC_CPCAP
> + tristate "Motorola CPCAP codec"
> + depends on MFD_CPCAP
> + default MFD_CPCAP
> +

We don't have default lines like this for other MFDs...

> + SOC_ENUM("Hifi Left Phase Playback Switch",
> + cpcap_hifi_l_phase_inv_enum),
> + SOC_ENUM("Ext Left Phase Playback Switch",
> + cpcap_ext_l_phase_inv_enum),

If this is a Switch control it should be a simple on/off binary control.
If it's an enumeration it shouldn't have Switch at the end of the name
since that's a keyword interpreted by userspace. Either option seems
fine in this case, if it's a switch it should be "Foo Invert Switch" or
similar.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-02-16 12:40    [W:0.098 / U:23.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site