lkml.org 
[lkml]   [2018]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] sched: Rename root_domain->overload to should_idle_balance
On Fri, Feb 16, 2018 at 10:14:02AM +0100, Juri Lelli wrote:
> > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> > index 7d324b706e67..4215438667e5 100644
> > --- a/kernel/sched/sched.h
> > +++ b/kernel/sched/sched.h
> > @@ -650,8 +650,12 @@ struct root_domain {
> > cpumask_var_t span;
> > cpumask_var_t online;
> >
> > - /* Indicate more than one runnable task for any CPU */
> > - bool overload;
> > + /*
> > + * Indicate whether the idle balance can be used to solve
> > + * imbalance within the root domain.
> > + * e.g. There is more than one runnable task for any CPU
> > + */
> > + bool should_idle_balance;
>
> Current name is however consistent with RT/DL's naming convention

Yeah, not a fan either. We've consistently used the term to mean
nr_running>1. The thing to fix there is the stupid bool, not the name.

\
 
 \ /
  Last update: 2018-02-16 10:49    [W:0.069 / U:1.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site