Messages in this thread | | | From | Tim Harvey <> | Date | Thu, 15 Feb 2018 09:43:38 -0800 | Subject | Re: [PATCH v12 6/8] media: i2c: Add TDA1997x HDMI receiver driver |
| |
On Thu, Feb 15, 2018 at 9:16 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote: > On 15/02/18 17:39, Tim Harvey wrote: >> Add support for the TDA1997x HDMI receivers. >> >> Cc: Hans Verkuil <hverkuil@xs4all.nl> >> Signed-off-by: Tim Harvey <tharvey@gateworks.com> >> --- >> v12: >> - fix coccinelle warnings > > Did you post the right version? I still see the owner being set and the > other kbuild warning ('note: in expansion of macro 'v4l_dbg'') is also > still there. > > Note that the last one also shows these errors: > > drivers/media/i2c/tda1997x.c:387:5-8: WARNING: Unsigned expression compared with zero: val < 0 > drivers/media/i2c/tda1997x.c:391:5-8: WARNING: Unsigned expression compared with zero: val < 0 > drivers/media/i2c/tda1997x.c:404:5-8: WARNING: Unsigned expression compared with zero: val < 0 > drivers/media/i2c/tda1997x.c:408:5-8: WARNING: Unsigned expression compared with zero: val < 0 > drivers/media/i2c/tda1997x.c:412:5-8: WARNING: Unsigned expression compared with zero: val < 0 > drivers/media/i2c/tda1997x.c:427:6-9: WARNING: Unsigned expression compared with zero: val < 0 > > This is indeed wrong. > > Regards, > > Hans
oh geez... no I goofed that up. I'll send a v13 now.
Tim
| |