lkml.org 
[lkml]   [2018]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v15 07/11] fw_cfg: remove inline from fw_cfg_read_blob()
    Date
    The function is not small and getting bigger.

    Let the compiler decide instead. No profiling done, hopefully
    unnecessary.

    Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    ---
    drivers/firmware/qemu_fw_cfg.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
    index 805372e8e50d..f6f90bef604c 100644
    --- a/drivers/firmware/qemu_fw_cfg.c
    +++ b/drivers/firmware/qemu_fw_cfg.c
    @@ -59,8 +59,8 @@ static void fw_cfg_sel_endianness(u16 key)
    }

    /* read chunk of given fw_cfg blob (caller responsible for sanity-check) */
    -static inline void fw_cfg_read_blob(u16 key,
    - void *buf, loff_t pos, size_t count)
    +static void fw_cfg_read_blob(u16 key,
    + void *buf, loff_t pos, size_t count)
    {
    u32 glk = -1U;
    acpi_status status;
    --
    2.16.1.73.g5832b7e9f2
    \
     
     \ /
      Last update: 2018-02-15 22:35    [W:2.387 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site