lkml.org 
[lkml]   [2018]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    SubjectRe: [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver
    On Wed, Feb 14, 2018 at 2:21 PM, Cosmin-Gabriel Samoila
    <cosmin.samoila@nxp.com> wrote:
    > The AK4458 is a 32-bit 8ch Premium DAC that corresponds
    > to a 768kHz PCM input and an 11.2MHz DSD input at maximum.
    > It supports I2S, DSD and TDM modes with 24 or 32 bit MSB
    > or 16, 24, 32 LSB formats. Its datasheet is available here:
    > https://www.akm.com/akm/en/file/datasheet/AK4458VN.pdf
    >
    > Signed-off-by: Junichi Wakasugi <wakasugi.jb@om.asahi-kasei.co.jp>
    > Signed-off-by: Mihai Serban <mihai.serban@nxp.com>
    > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
    > Signed-off-by: Cosmin-Gabriel Samoila <cosmin.samoila@nxp.com>
    > ---

    > --- /dev/null
    > +++ b/sound/soc/codecs/ak4458.c
    > @@ -0,0 +1,659 @@
    > +// SPDX-License-Identifier: GPL-2.0
    > +/*
    > + * Audio driver for AK4458 DAC
    > + *
    > + * Copyright (C) 2016 Asahi Kasei Microdevices Corporation
    > + * Copyright 2018 NXP

    Thanks for using the proper SPDX tag here.... yet see my comments below.

    <snip>

    > +MODULE_AUTHOR("Junichi Wakasugi <wakasugi.jb@om.asahi-kasei.co.jp>");
    > +MODULE_AUTHOR("Mihai Serban <mihai.serban@nxp.com>");
    > +MODULE_DESCRIPTION("ASoC AK4458 DAC driver");
    > +MODULE_LICENSE("GPL");

    This means GPL-2.0+ per module.h and therefore does not match your
    GPL-2.0 SPDX tag above.
    Go one way or the other, but not both way please.

    > diff --git a/sound/soc/codecs/ak4458.h b/sound/soc/codecs/ak4458.h
    > new file mode 100644
    > index 0000000..16d9d22
    > --- /dev/null
    > +++ b/sound/soc/codecs/ak4458.h
    > @@ -0,0 +1,86 @@
    > +// SPDX-License-Identifier: GPL-2.0
    As weird as it sounds the style should be plain /*
    SPDX-License-Identifier: GPL-2.0 /* here per [1]
    [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

    --
    Cordially
    Philippe Ombredanne

    \
     
     \ /
      Last update: 2018-02-14 22:36    [W:3.103 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site