lkml.org 
[lkml]   [2018]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/5] dmaengine: qcom: bam_dma: make bam clk optional
On Wed 14 Feb 10:19 PST 2018, Srinivas Kandagatla wrote:

> Thanks for the Review,
>
> On 14/02/18 15:41, Bjorn Andersson wrote:
> > > bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk");
> > > - if (IS_ERR(bdev->bamclk))
> > > - return PTR_ERR(bdev->bamclk);
> > > -
> > > - ret = clk_prepare_enable(bdev->bamclk);
> > > - if (ret) {
> > > - dev_err(bdev->dev, "failed to prepare/enable clock\n");
> > > - return ret;
> > > + if (IS_ERR(bdev->bamclk)) {
> > In the case of !bdev->controlled_remotely I think this should still be
> > an error.
> >
> Yep makes sense,
>
> You mean something like this?
>
> ------------------------->cut<------------------------
> bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk");
> if (IS_ERR(bdev->bamclk)) {
> if (!bdev->controlled_remotely);
> return PTR_ERR(bdev->bamclk);
>
> bdev->bamclk = NULL;
> }
>
> ret = clk_prepare_enable(bdev->bamclk);
> if (ret) {
> dev_err(bdev->dev, "failed to prepare/enable clock\n");
> return ret;
> }
>
> ------------------------->cut<------------------------
>

Yes

Regards,
Bjorn

\
 
 \ /
  Last update: 2018-02-14 19:48    [W:0.042 / U:0.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site