Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [2/2] powerpc/pseries: Declare optional dummy function for find_and_online_cpu_nid | Date | Wed, 14 Feb 2018 16:43:48 +1100 (AEDT) |
| |
On Mon, 2018-02-12 at 22:34:08 UTC, Guenter Roeck wrote: > Commit e67e02a544e9 ("powerpc/pseries: Fix cpu hotplug crash with > memoryless nodes") adds an unconditional call to find_and_online_cpu_nid(), > which is only declared if CONFIG_PPC_SPLPAR is enabled. This results in > the following build error if this is not the case. > > arch/powerpc/platforms/pseries/hotplug-cpu.o: In function `dlpar_online_cpu': > arch/powerpc/platforms/pseries/hotplug-cpu.c:369: > undefined reference to `.find_and_online_cpu_nid' > > Follow the guideline provided by similar functions and provide a dummy > function if CONFIG_PPC_SPLPAR is not enabled. This also moves the external > function declaration into an include file where it should be. > > Fixes: e67e02a544e9 ("powerpc/pseries: Fix cpu hotplug crash with ...") > Cc: Michael Bringmann <mwb@linux.vnet.ibm.com> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/82343484a2d4c97a03bfd81303b549
cheers
| |