Messages in this thread | | | From | Bart Van Assche <> | Subject | Re: [PATCH] lib/scatterlist: Add SG_CHAIN and SG_EMARK macros for LSB encodings | Date | Wed, 14 Feb 2018 16:03:49 +0000 |
| |
On Wed, 2018-02-14 at 10:28 +0530, Anshuman Khandual wrote: > +#define SG_CHAIN 0x01 > +#define SG_EMARK 0x02
Hello Anshuman,
As you probably know constants that do not have a suffix are of type int. Please consider to add suffix "UL" to these constants to avoid that the compiler could take an undesired decision when e.g. converting ~SG_CHAIN from int to unsigned long.
Thanks,
Bart. | |