Messages in this thread | | | Subject | Re: efi/apple-properties: Checking error handling in unmarshal_devices() | From | SF Markus Elfring <> | Date | Wed, 14 Feb 2018 09:21:00 +0100 |
| |
> While the allocator does print an error when allocations fail, > it may not be immediately apparent to the user what the > *consequences* are. In this case, the consequence is that the > device properties will not be available for consumption by > drivers and they may fail to probe or behave in entirely > unexpected ways.
Would it make sense to indicate such a questionable software situation be any return code?
> Hence I deliberately printed an error message here so that the user > can make the connection between erratic behavior of drivers later on > and the memory allocation error here.
Do you find this terse message really sufficient?
Can the mentioned properties be required for the desired system configuration?
Regards, Markus
| |