lkml.org 
[lkml]   [2018]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] irqchip/irq-imx-gpcv2: Remove unused function
From
Date
On 12/02/18 13:12, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> imx_gpcv2_get_wakeup_source() is not used anywhere, so remove it.
>
> This fixes the following sparse warning:
>
> drivers/irqchip/irq-imx-gpcv2.c:34:5: warning: symbol 'imx_gpcv2_get_wakeup_source' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/irqchip/irq-imx-gpcv2.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
> index 675eda5..4760307 100644
> --- a/drivers/irqchip/irq-imx-gpcv2.c
> +++ b/drivers/irqchip/irq-imx-gpcv2.c
> @@ -28,20 +28,6 @@ struct gpcv2_irqchip_data {
>
> static struct gpcv2_irqchip_data *imx_gpcv2_instance;
>
> -/*
> - * Interface for the low level wakeup code.
> - */
> -u32 imx_gpcv2_get_wakeup_source(u32 **sources)
> -{
> - if (!imx_gpcv2_instance)
> - return 0;
> -
> - if (sources)
> - *sources = imx_gpcv2_instance->wakeup_sources;
> -
> - return IMR_NUM;
> -}
> -
> static int gpcv2_wakeup_source_save(void)
> {
> struct gpcv2_irqchip_data *cd;
>

I'll queue this up for -rc2, with this addition:

Fixes: e324c4dc4a59 ("irqchip/imx-gpcv2: IMX GPCv2 driver for wakeup
sources")

Thanks,

M.
--
Jazz is not dead. It just smells funny...

\
 
 \ /
  Last update: 2018-02-12 14:23    [W:0.048 / U:1.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site