Messages in this thread | | | Subject | Re: [RFC PATCH 4/7] kconfig: support new special property shell= | From | Randy Dunlap <> | Date | Mon, 12 Feb 2018 17:53:05 -0800 |
| |
On 02/12/2018 05:41 PM, Masahiro Yamada wrote: > 2018-02-13 8:48 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>: >> On 02/12/2018 07:24 AM, Kees Cook wrote: >>> On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada >>> <yamada.masahiro@socionext.com> wrote: >> >>>>> (And in thinking about this, does Kconfig know the true $CC in use? >>>>> i.e. the configured cross compiler, etc?) >>>> >>>> I was thinking of removing CONFIG_CROSS_COMPILE. >>>> >>>> A user can dynamically change CROSS_COMPILE from >>>> "make menuconfig". >>> >>> Most builds I've seen implement cross compilers as an environment >>> variable during all "make" invocations. >> >> I agree. I think you would break a bunch of build bots if you remove that. > > > For clarification, I suggested to remove CONFIG_CROSS_COMPILE. > > The following code: > https://github.com/torvalds/linux/blob/v4.16-rc1/Makefile#L315 > https://github.com/torvalds/linux/blob/v4.16-rc1/init/Kconfig#L58 > > I hope build bots are not using this. > > > Passing CROSS_COMPILE via the command line, environment > is still supported.
OK, I misunderstood. That one can go away IMO.
thanks, -- ~Randy
| |