lkml.org 
[lkml]   [2018]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] perf kmem: Document a missing option & an argument
On Mon, Feb 12, 2018 at 05:38:36AM +0900, Sangwon Hong wrote:
> First, perf kmem has --force option, but didn't document it on the man
> page. So add missing --force option.
>
> Second, --time option has to get a value, but didn't specify it on the
> man page. So describe --time option's argument.
>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Taeung Song <treeze.taeung@gmail.com>
> Signed-off-by: Sangwon Hong <qpakzk@gmail.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

A nit below though..


> ---
> tools/perf/Documentation/perf-kmem.txt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/Documentation/perf-kmem.txt b/tools/perf/Documentation/perf-kmem.txt
> index 479fc32..c4aa843 100644
> --- a/tools/perf/Documentation/perf-kmem.txt
> +++ b/tools/perf/Documentation/perf-kmem.txt
> @@ -25,6 +25,9 @@ OPTIONS
> --input=<file>::
> Select the input file (default: perf.data unless stdin is a fifo)
>
> +-f::
> +--force::
> + Don't do ownership validation

Please add a blank line here

Thanks,
Namhyung


> -v::
> --verbose::
> Be more verbose. (show symbol address, etc)
> @@ -61,7 +64,7 @@ OPTIONS
> default, but this option shows live (currently allocated) pages
> instead. (This option works with --page option only)
>
> ---time::
> +--time=<start>,<stop>::
> Only analyze samples within given time window: <start>,<stop>. Times
> have the format seconds.microseconds. If start is not given (i.e., time
> string is ',x.y') then analysis starts at the beginning of the file. If
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2018-02-12 02:52    [W:0.094 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site