lkml.org 
[lkml]   [2018]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 3/3] auxdisplay: charlcd: replace octal literal with form-feed escape sequence
    On Sat, Feb 10, 2018 at 12:50 AM, Robert Abel <rabel@robertabel.eu> wrote:
    > There is no need to resort to octal escape sequence for the form feed character when an established escape sequence exists.
    >
    > Signed-off-by: Robert Abel <rabel@robertabel.eu>
    > ---
    > drivers/auxdisplay/charlcd.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c
    > index 92549c8344a4..a3486db03d81 100644
    > --- a/drivers/auxdisplay/charlcd.c
    > +++ b/drivers/auxdisplay/charlcd.c
    > @@ -555,7 +555,7 @@ static void charlcd_write_char(struct charlcd *lcd, char c)
    > /* back one char again */
    > lcd->ops->write_cmd(lcd, LCD_CMD_SHIFT);
    > break;
    > - case '\014':
    > + case '\f':

    Normally I wouldn't bother with this kind of change, but since the
    other switch cases all use escape sequences, this improves
    consistency, so agreed.

    Trivial. Compile-tested.

    Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>

    > /* quickly clear the display */
    > charlcd_clear_fast(lcd);
    > break;
    > --
    > 2.11.0
    >

    \
     
     \ /
      Last update: 2018-02-10 10:44    [W:4.112 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site