lkml.org 
[lkml]   [2018]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 119/136] RDS: Heap OOB write in rds_message_alloc_sgs()
    3.16.54-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mohamed Ghannam <simo.ghannam@gmail.com>

    commit c095508770aebf1b9218e77026e48345d719b17c upstream.

    When args->nr_local is 0, nr_pages gets also 0 due some size
    calculation via rds_rm_size(), which is later used to allocate
    pages for DMA, this bug produces a heap Out-Of-Bound write access
    to a specific memory region.

    Signed-off-by: Mohamed Ghannam <simo.ghannam@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    net/rds/rdma.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/net/rds/rdma.c
    +++ b/net/rds/rdma.c
    @@ -516,6 +516,9 @@ int rds_rdma_extra_size(struct rds_rdma_

    local_vec = (struct rds_iovec __user *)(unsigned long) args->local_vec_addr;

    + if (args->nr_local == 0)
    + return -EINVAL;
    +
    /* figure out the number of pages in the vector */
    for (i = 0; i < args->nr_local; i++) {
    if (copy_from_user(&vec, &local_vec[i],
    \
     
     \ /
      Last update: 2018-02-11 05:52    [W:4.039 / U:0.592 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site