Messages in this thread | | | From | Philippe Ombredanne <> | Date | Sat, 10 Feb 2018 08:36:21 +0100 | Subject | Re: [PATCH v3 01/11] dt-bindings: clock: Add Actions S900 clock bindings |
| |
Dear Manivannan,
On Sat, Feb 10, 2018 at 3:41 AM, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > Add Actions Semi S900 clock bindings. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Acked-by: Rob Herring <robh@kernel.org>
<snip>
> diff --git a/include/dt-bindings/clock/actions,s900-cmu.h b/include/dt-bindings/clock/actions,s900-cmu.h > new file mode 100644 > index 000000000000..2fa94e19922b > --- /dev/null > +++ b/include/dt-bindings/clock/actions,s900-cmu.h > @@ -0,0 +1,139 @@ > +/* > + * Device Tree binding constants for Actions S900 Clock Management Unit > + * > + * Copyright (c) 2014 Actions Semi Inc. > + * Copyright (c) 2017 Linaro Ltd. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */
Would you consider using the new SPDX license ids rather that this time-tested but rather boring legalese?
The (still new and fresh) license documentation contributed by tglx --the only maintainer that I know that understands both the innards of Spectre and Meltdown and the beauty of reStructuredText -- is in: Documentation/process/license-rules.rst
Practically this means replacing the above by a simple single line and getting rid of a whopping 8 comment lines!
SPDX-License-Identifier: GPL-2.0+
You get to save a few tree as a bonus if you also do the same for all Linaro-copyrighted files. Yes this is saving trees because I will use less paper each time I print a listing of the kernel source code. Which is something that I rarely if ever do: but somebody must do it somewhere for sure.
If I do the math: we have ~60K files in the kernel, and say we can remove roughly 5 lines of legalese per file on average. Each printed source code page is roughly 60 lines : this will mean a saving of about 6000 paper sheets saved on each printout! A letter-size paper ream is 500 pages, about 2.5 Kg and costs about ~$8. You can extract about 10K to 20k sheets of paper per tree [1]. Therefore my Fermi estimate is that using shorter legalese in the kernel will eventually save roughly ONE FULL smaller tree (6K pages) each time someone prints the kernel code: incredible, right?
Thank you for helping make the kernel a mostly legalese-free codebase and saving trees at the same time!
[1] https://www.sierraclub.org/sierra/2014-4-july-august/green-life/how-much-paper-does-one-tree-produce -- Cordially Philippe Ombredanne
| |