Messages in this thread | | | Date | Sat, 10 Feb 2018 08:23:40 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 4.9 46/92] x86/alternative: Print unadorned pointers |
| |
On Fri, Feb 09, 2018 at 02:01:32PM -0800, Kees Cook wrote: > On Fri, Feb 9, 2018 at 5:39 AM, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > 4.9-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Borislav Petkov <bp@suse.de> > > > > (cherry picked from commit 0e6c16c652cadaffd25a6bb326ec10da5bcec6b4) > > > > After commit ad67b74d2469 ("printk: hash addresses printed with %p") > > pointers are being hashed when printed. However, this makes the alternative > > debug output completely useless. Switch to %px in order to see the > > unadorned kernel pointers. > > This missed a "Fixes:" tag so probably missed automated checking on > how far back to port this. It shouldn't go back beyond 4.15 (where > ad67b74d2469 first appeared).
Good point. Should we instead be using %pK for this change instead? Or should we just backport commit ad67b74d2469 to 4.14? :)
Thanks for letting me know this.
greg k-h
| |