Messages in this thread | | | Date | Thu, 1 Feb 2018 10:56:13 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [tip:irq/urgent] genirq: Make legacy autoprobing work again |
| |
On Thu, 1 Feb 2018, Geert Uytterhoeven wrote: > On Wed, Jan 31, 2018 at 10:54 AM, tip-bot for Thomas Gleixner > > -void irq_activate_and_startup(struct irq_desc *desc, bool resend) > > +int irq_activate_and_startup(struct irq_desc *desc, bool resend) > > { > > if (WARN_ON(irq_activate(desc))) > > return; > > As reported by 0day, this should return something. > > if CONFIG_IRQ_DOMAIN=n or CONFIG_IRQ_DOMAIN_HIERARCHY=n, > irq_activate() will never return 1, and the code path can be eliminated. > > BTW, is gcc becoming too smart, and already eliminating code before it > generates warnings for it? Recently I've seen some other cases where buggy > code was not warned about, as it was considered not having any impact.
Looks like. Fixed it up.
Thanks,
tglx
| |