lkml.org 
[lkml]   [2018]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 158/328] mm: move tlb_table_flush to tlb_flush_mmu_free
    3.16.62-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nicholas Piggin <npiggin@gmail.com>

    commit db7ddef301128dad394f1c0f77027f86ee9a4edb upstream.

    There is no need to call this from tlb_flush_mmu_tlbonly, it logically
    belongs with tlb_flush_mmu_free. This makes future fixes simpler.

    [ This was originally done to allow code consolidation for the
    mmu_notifier fix, but it also ends up helping simplify the
    HAVE_RCU_TABLE_INVALIDATE fix. - Linus ]

    Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
    Acked-by: Will Deacon <will.deacon@arm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    [bwh: Backported to 3.16: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    mm/memory.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/mm/memory.c
    +++ b/mm/memory.c
    @@ -236,15 +236,15 @@ static void tlb_flush_mmu_tlbonly(struct
    {
    tlb->need_flush = 0;
    tlb_flush(tlb);
    -#ifdef CONFIG_HAVE_RCU_TABLE_FREE
    - tlb_table_flush(tlb);
    -#endif
    }

    static void tlb_flush_mmu_free(struct mmu_gather *tlb)
    {
    struct mmu_gather_batch *batch;

    +#ifdef CONFIG_HAVE_RCU_TABLE_FREE
    + tlb_table_flush(tlb);
    +#endif
    for (batch = &tlb->local; batch; batch = batch->next) {
    free_pages_and_swap_cache(batch->pages, batch->nr);
    batch->nr = 0;
    \
     
     \ /
      Last update: 2018-12-09 23:24    [W:4.130 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site