lkml.org 
[lkml]   [2018]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 122/328] b43legacy/leds: Ensure NUL-termination of LED name string
    3.16.62-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Michael Büsch <m@bues.ch>

    commit 4d77a89e3924b12f4a5628b21237e57ab4703866 upstream.

    strncpy might not NUL-terminate the string, if the name equals the buffer size.
    Use strlcpy instead.

    Signed-off-by: Michael Buesch <m@bues.ch>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    [bwh: Backported to 3.16: adjust filename]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/wireless/b43legacy/leds.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/wireless/b43legacy/leds.c
    +++ b/drivers/net/wireless/b43legacy/leds.c
    @@ -101,7 +101,7 @@ static int b43legacy_register_led(struct
    led->dev = dev;
    led->index = led_index;
    led->activelow = activelow;
    - strncpy(led->name, name, sizeof(led->name));
    + strlcpy(led->name, name, sizeof(led->name));

    led->led_dev.name = led->name;
    led->led_dev.default_trigger = default_trigger;
    \
     
     \ /
      Last update: 2018-12-09 23:18    [W:4.082 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site