lkml.org 
[lkml]   [2018]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 201/328] spi: sh-msiof: Fix handling of write value for SISTR register
    3.16.62-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>

    commit 31a5fae4c5a009898da6d177901d5328051641ff upstream.

    This patch changes writing to the SISTR register according to the H/W
    user's manual.

    The TDREQ bit and RDREQ bits of SISTR are read-only, and must be written
    their initial values of zero.

    Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
    [geert: reword]
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/spi/spi-sh-msiof.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/spi/spi-sh-msiof.c
    +++ b/drivers/spi/spi-sh-msiof.c
    @@ -325,7 +325,8 @@ static void sh_msiof_spi_set_mode_regs(s

    static void sh_msiof_reset_str(struct sh_msiof_spi_priv *p)
    {
    - sh_msiof_write(p, STR, sh_msiof_read(p, STR));
    + sh_msiof_write(p, STR,
    + sh_msiof_read(p, STR) & ~(STR_TDREQ | STR_RDREQ));
    }

    static void sh_msiof_spi_write_fifo_8(struct sh_msiof_spi_priv *p,
    \
     
     \ /
      Last update: 2018-12-09 23:18    [W:2.981 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site