lkml.org 
[lkml]   [2018]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 083/328] iio: ad9523: Fix return value for ad952x_store()
    3.16.62-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Lars-Peter Clausen <lars@metafoo.de>

    commit 9a5094ca29ea9b1da301b31fd377c0c0c4c23034 upstream.

    A sysfs write callback function needs to either return the number of
    consumed characters or an error.

    The ad952x_store() function currently returns 0 if the input value was "0",
    this will signal that no characters have been consumed and the function
    will be called repeatedly in a loop indefinitely. Fix this by returning
    number of supplied characters to indicate that the whole input string has
    been consumed.

    Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
    Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
    Fixes: cd1678f96329 ("iio: frequency: New driver for AD9523 SPI Low Jitter Clock Generator")
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/iio/frequency/ad9523.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/iio/frequency/ad9523.c
    +++ b/drivers/iio/frequency/ad9523.c
    @@ -507,7 +507,7 @@ static ssize_t ad9523_store(struct devic
    return ret;

    if (!state)
    - return 0;
    + return len;

    mutex_lock(&indio_dev->mlock);
    switch ((u32)this_attr->address) {
    \
     
     \ /
      Last update: 2018-12-09 23:09    [W:4.320 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site