lkml.org 
[lkml]   [2018]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 249/328] x86/paravirt: Fix some warning messages
    3.16.62-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 571d0563c8881595f4ab027aef9ed1c55e3e7b7c upstream.

    The first argument to WARN_ONCE() is a condition.

    Fixes: 5800dc5c19f3 ("x86/paravirt: Fix spectre-v2 mitigations for paravirt guests")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Reviewed-by: Juergen Gross <jgross@suse.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Alok Kataria <akataria@vmware.com>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: virtualization@lists.linux-foundation.org
    Cc: kernel-janitors@vger.kernel.org
    Link: https://lkml.kernel.org/r/20180919103553.GD9238@mwanda
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    arch/x86/kernel/paravirt.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/arch/x86/kernel/paravirt.c
    +++ b/arch/x86/kernel/paravirt.c
    @@ -99,7 +99,7 @@ unsigned paravirt_patch_call(void *insnb

    if (len < 5) {
    #ifdef CONFIG_RETPOLINE
    - WARN_ONCE("Failing to patch indirect CALL in %ps\n", (void *)addr);
    + WARN_ONCE(1, "Failing to patch indirect CALL in %ps\n", (void *)addr);
    #endif
    return len; /* call too long for patch site */
    }
    @@ -119,7 +119,7 @@ unsigned paravirt_patch_jmp(void *insnbu

    if (len < 5) {
    #ifdef CONFIG_RETPOLINE
    - WARN_ONCE("Failing to patch indirect JMP in %ps\n", (void *)addr);
    + WARN_ONCE(1, "Failing to patch indirect JMP in %ps\n", (void *)addr);
    #endif
    return len; /* call too long for patch site */
    }
    \
     
     \ /
      Last update: 2018-12-09 22:58    [W:2.444 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site