Messages in this thread | | | From | Frank Lee <> | Date | Sun, 9 Dec 2018 14:20:26 +0800 | Subject | Re: [PATCH v3] cpuidle: big.LITTLE: add of_node_put() |
| |
On Wed, Nov 21, 2018 at 12:14 AM Yangtao Li <tiny.windzz@gmail.com> wrote: > > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > bl_idle_init() doesn't do that, so fix it. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > Changes in v3: > -update changelog > --- > drivers/cpuidle/cpuidle-big_little.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c > index db2ede565f1a..650f063ef809 100644 > --- a/drivers/cpuidle/cpuidle-big_little.c > +++ b/drivers/cpuidle/cpuidle-big_little.c > @@ -174,8 +174,12 @@ static int __init bl_idle_init(void) > /* > * Initialize the driver just for a compliant set of machines > */ > - if (!of_match_node(compatible_machine_match, root)) > + if (!of_match_node(compatible_machine_match, root)){ > + of_node_put(root); > return -ENODEV; > + } > + > + of_node_put(root); > > if (!mcpm_is_available()) > return -EUNATCH; > -- > 2.17.0 > ping......
| |