lkml.org 
[lkml]   [2018]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver
    From
    Date
    On 12/06/2018 10:12 AM, Geert Uytterhoeven wrote:
    > Hi Mason,
    >
    > On Thu, Dec 6, 2018 at 8:31 AM <masonccyang@mxic.com.tw> wrote:
    >>>>> Re: [PATCH v2 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver
    >>>>>
    >>>>> On 12/03/2018 10:18 AM, Mason Yang wrote:
    >>>>>> Add a driver for Renesas R-Car Gen3 RPC SPI controller.
    >>>>>>
    >>>>>> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
    >
    >>>>>> + xfercnt = xferpos;
    >>>>>> + rpc->xferlen = xfer[--xferpos].len;
    >>>>>> + rpc->cmd = RPC_SMCMR_CMD(((u8 *)xfer[0].tx_buf)[0]);
    >>>>>
    >>>>> Is the cast needed ?
    >>>>
    >>>> yes!
    >>>
    >>> Why ?
    >>
    >> Get a compiler warning due to tx_bug is void *, as Geert replied.
    >>
    >> Using get_unaligned(), patched code would be
    >> ---------------------------------------------------------------
    >> rpc->cmd = RPC_SMCMR_CMD(get_unaligned((u8 *)xfer[0].tx_buf));
    >> ----------------------------------------------------------------
    >
    > Using get_unaligned(0 is a bit strange for accessing a single byte quantity.
    > Please keep the normal pointer dereference (including the cast).

    Oh, right, for single bytes this is OK.

    --
    Best regards,
    Marek Vasut

    \
     
     \ /
      Last update: 2018-12-06 10:15    [W:6.959 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site