Messages in this thread Patch in this message | | | Date | Wed, 5 Dec 2018 02:03:53 -0800 | From | tip-bot for Bart Van Assche <> | Subject | [tip:timers/core] timekeeping: Use proper seqcount initializer |
| |
Commit-ID: ce10a5b3954f2514af726beb78ed8d7350c5e41c Gitweb: https://git.kernel.org/tip/ce10a5b3954f2514af726beb78ed8d7350c5e41c Author: Bart Van Assche <bvanassche@acm.org> AuthorDate: Wed, 28 Nov 2018 15:43:09 -0800 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Wed, 5 Dec 2018 11:00:09 +0100
timekeeping: Use proper seqcount initializer
tk_core.seq is initialized open coded, but that misses to initialize the lockdep map when lockdep is enabled. Lockdep splats involving tk_core seq consequently lack a name and are hard to read.
Use the proper initializer which takes care of the lockdep map initialization.
[ tglx: Massaged changelog ]
Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: peterz@infradead.org Cc: tj@kernel.org Cc: johannes.berg@intel.com Link: https://lkml.kernel.org/r/20181128234325.110011-12-bvanassche@acm.org
--- kernel/time/timekeeping.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index cd02bd38cf2d..c801e25875a3 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -45,7 +45,9 @@ enum timekeeping_adv_mode { static struct { seqcount_t seq; struct timekeeper timekeeper; -} tk_core ____cacheline_aligned; +} tk_core ____cacheline_aligned = { + .seq = SEQCNT_ZERO(tk_core.seq), +}; static DEFINE_RAW_SPINLOCK(timekeeper_lock); static struct timekeeper shadow_timekeeper;
| |