| Date | Wed, 5 Dec 2018 14:05:06 -0500 | From | Joe Lawrence <> | Subject | Re: [PATCH v14 04/11] livepatch: Refuse to unload only livepatches available during a forced transition |
| |
On Thu, Nov 29, 2018 at 10:44:24AM +0100, Petr Mladek wrote: > module_put() is currently never called in klp_complete_transition() when > klp_force is set. As a result, we might keep the reference count even when > klp_enable_patch() fails and klp_cancel_transition() is called. > > This might make an assumption that a module might get blocked in some ^^^^^^^^^^^^^^^^^^ re-wording suggestion: "give the impression"
> strange init state. Fortunately, it is not the case. The reference count > is ignored when mod->init fails and erroneous modules are always removed. > > Anyway, this might make some confusion. Instead, this patch moves ^^^^^^^^^^^^^^^^^^^ re-wording suggestions: "create confusion" or "be confusing"
> the global klp_forced flag into struct klp_patch. As a result, > we block only modules that might still be in use after a forced > transition. Newly loaded livepatches might be eventually completely > removed later. > > It is not a big deal. But the code is at least consistent with > the reality. > > Signed-off-by: Petr Mladek <pmladek@suse.com>
Acked-by: Joe Lawrence <joe.lawrence@redhat.com>
-- Joe
|