Messages in this thread | | | Subject | Re: [PATCH] perf/core: declare the percpu variable properly | From | Mukesh Ojha <> | Date | Wed, 5 Dec 2018 13:13:17 +0530 |
| |
Hi All,
Can you please review the change ?
Thanks, Mukesh
On 11/27/2018 2:43 PM, Mukesh Ojha wrote: > Sparse reports the current declaration of percpu variable with > below warning > > warning: incorrect type in initializer (different address spaces) > expected void const [noderef] <asn:3>*__vpp_verify > got struct perf_cpu_context *<noident> > > Fix it by declaring it properly. > > Signed-off-by: Mukesh Ojha <mojha@codeaurora.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org> > Cc: Jiri Olsa <jolsa@redhat.com> > Cc: Namhyung Kim <namhyung@kernel.org> > > --- > include/linux/perf_event.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index 53c500f..1d5c551 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -262,8 +262,8 @@ struct pmu { > */ > int capabilities; > > - int * __percpu pmu_disable_count; > - struct perf_cpu_context * __percpu pmu_cpu_context; > + int __percpu *pmu_disable_count; > + struct perf_cpu_context __percpu *pmu_cpu_context; > atomic_t exclusive_cnt; /* < 0: cpu; > 0: tsk */ > int task_ctx_nr; > int hrtimer_interval_ms;
| |