Messages in this thread | | | Subject | Re: [PATCH v5 2/7] tpm: remove definition of TPM2_ACTIVE_PCR_BANKS | From | Roberto Sassu <> | Date | Mon, 3 Dec 2018 10:59:10 +0100 |
| |
On 11/30/2018 8:45 PM, Jarkko Sakkinen wrote: > On Fri, Nov 30, 2018 at 11:41:49AM -0800, Jarkko Sakkinen wrote: >> Even after looking at the spec the last field does not make sense as the >> event after digests and digests are not in union. It is just not right. >> >> The comment does not fix that. > > You should remove the last field and rename the struct as maybe > struct tcg_pcr_event2_head. If we ever need the very last field > we can create struct *_tail. > > Not your fault but there is clear bug in the struct definition > that should be fixed in a commit of its own.
Given that I explain the problem in the new patch, I would also remove TPM2_ACTIVE_PCR_BANKS in the same patch. Is it ok?
Thanks
Roberto
> No new comments are needed. > > /Jarkko >
-- HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Bo PENG, Jian LI, Yanli SHI
| |