lkml.org 
[lkml]   [2018]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] sound:emu10k1:Use kmemdup instead of duplicating its function
    Date
    From: "huang.zijiang" <huang.zijiang@zte.com.cn>

    kmemdup has implemented the function that kmalloc() and memcpy().

    Signed-off-by: huang.zijiang <huang.zijiang@zte.com.cn>
    ---
    sound/pci/emu10k1/emufx.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c
    index 6ebe817..b4fe4c5 100644
    --- a/sound/pci/emu10k1/emufx.c
    +++ b/sound/pci/emu10k1/emufx.c
    @@ -671,10 +671,9 @@ static unsigned int *copy_tlv(const unsigned int __user *_tlv, bool in_kernel)
    return NULL;
    if (data[1] >= MAX_TLV_SIZE)
    return NULL;
    - tlv = kmalloc(data[1] + sizeof(data), GFP_KERNEL);
    + tlv = kmemdup(data, data[1] + sizeof(data), GFP_KERNEL);
    if (!tlv)
    return NULL;
    - memcpy(tlv, data, sizeof(data));
    if (in_kernel) {
    memcpy(tlv + 2, (__force void *)(_tlv + 2), data[1]);
    } else if (copy_from_user(tlv + 2, _tlv + 2, data[1])) {
    --
    1.8.3.1
    \
     
     \ /
      Last update: 2018-12-24 09:41    [W:4.865 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site