Messages in this thread | | | Subject | Re: [PATCH v2 07/11] drivers: thermal: Hide PCI driver when CONFIG_PCI is unset | From | Sinan Kaya <> | Date | Sun, 23 Dec 2018 23:23:24 +0100 |
| |
On 12/23/2018 10:48 PM, Rafael J. Wysocki wrote: > Can you actually test this driver with your new #ifdef stuff and with > CONFIG_PCI unset? > > Have you really test it in that configuration? >
No, I haven't. Code was compile tested only.
> If not, you shouldn't even post this patch. >
I was hoping the maintainer to chime in. By looking at the code, it was registering a platform and PCI driver. I assumed that it was generic code that can be used with and without PCI.
> Please make the driver depend on PCI.
I can do that.
| |