Messages in this thread | | | Date | Fri, 21 Dec 2018 19:37:11 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH v3] string.h: Add str_has_prefix() helper |
| |
On Fri, 21 Dec 2018 16:32:58 -0800 Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Fri, Dec 21, 2018, 16:06 Steven Rostedt <rostedt@goodmis.org wrote: > > > On Fri, 21 Dec 2018 18:13:16 > > > > And I'll make a separate patch that adds: > > > > static __always_inline bool > > str_has_prefix_len(const char *str, const char *prefix, unsigned int *len) > > > Why would this ever be a good idea? What's the advantage over returning the > length?
Style?
I was just thinking that some people (like Joe) think it's in bad taste to have:
if ((len = str_has_prefix(str, "const"))) {
and it might look better to have:
if (str_has_prefix_len(str, "const", &len)) {
Honestly, I'm good with either and don't really have a preference.
Let me know which one you prefer, and I'll work to get a patch out.
-- Steve
| |