Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 21 Dec 2018 11:07:40 +0100 | Subject | Re: [PATCH] pinctrl: msm: mark PM functions as __maybe_unused |
| |
On Mon, Dec 10, 2018 at 9:59 PM Arnd Bergmann <arnd@arndb.de> wrote:
> Without CONFIG_PM_SLEEP, we get annoyting warnings about unused functions: > > drivers/pinctrl/qcom/pinctrl-msm.c:1082:12: error: 'msm_pinctrl_resume' defined but not used [-Werror=unused-function] > static int msm_pinctrl_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~ > drivers/pinctrl/qcom/pinctrl-msm.c:1075:12: error: 'msm_pinctrl_suspend' defined but not used [-Werror=unused-function] > static int msm_pinctrl_suspend(struct device *dev) > > Mark them as __maybe_unused to shut up the warning and silently drop > the functions without having to add ugly #ifdefs. > > Fixes: 977d057ad346 ("pinctrl: msm: Add sleep pinctrl state transitions") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied w/ACKs and fixing a typo.
Yours, Linus Walleij
| |