Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 20 Dec 2018 11:28:15 -0800 | Subject | Re: [PATCH v3 1/3] drm/msm/a6xx: Add support for an interconnect path |
| |
Hi,
On Thu, Dec 20, 2018 at 9:30 AM Jordan Crouse <jcrouse@codeaurora.org> wrote: > > Try to get the interconnect path for the GPU and vote for the maximum > bandwidth to support all frequencies. This is needed for performance. > Later we will want to scale the bandwidth based on the frequency to > also optimize for power but that will require some device tree > infrastructure that does not yet exist. > > v5: Remove hardcoded interconnect name and just use the default > v4: Don't use a port string at all to skip the need for names in the DT > v3: Use macros and change port string per Georgi Djakov > > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> > --- > > drivers/gpu/drm/msm/Kconfig | 1 + > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 20 ++++++++++++++++++++ > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 9 +++++++++ > drivers/gpu/drm/msm/msm_gpu.h | 3 +++ > 4 files changed, 33 insertions(+)
There is very little difference between this an the previous version [1]. Maybe could have kept Rob Clark's Acked-by? The only change was:
- gpu->icc_path = of_icc_get(dev, "gfx-mem"); + gpu->icc_path = of_icc_get(dev, NULL);
Also: I assume that this is still intended to go through Georgi's tree?
[1] https://lkml.kernel.org/r/20181207170656.13208-1-jcrouse@codeaurora.org
-Doug
| |