lkml.org 
[lkml]   [2018]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] [SCSI] zfcp: NULL check before some freeing functions is not needed.
    From
    Date
    NULL check before some freeing functions is not needed.

    Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
    ---

    diff -u -p a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi/zfcp_aux.c
    --- a/drivers/s390/scsi/zfcp_aux.c
    +++ b/drivers/s390/scsi/zfcp_aux.c
    @@ -248,20 +248,13 @@ static int zfcp_allocate_low_mem_buffers

    static void zfcp_free_low_mem_buffers(struct zfcp_adapter *adapter)
    {
    - if (adapter->pool.erp_req)
    - mempool_destroy(adapter->pool.erp_req);
    - if (adapter->pool.scsi_req)
    - mempool_destroy(adapter->pool.scsi_req);
    - if (adapter->pool.scsi_abort)
    - mempool_destroy(adapter->pool.scsi_abort);
    - if (adapter->pool.qtcb_pool)
    - mempool_destroy(adapter->pool.qtcb_pool);
    - if (adapter->pool.status_read_req)
    - mempool_destroy(adapter->pool.status_read_req);
    - if (adapter->pool.sr_data)
    - mempool_destroy(adapter->pool.sr_data);
    - if (adapter->pool.gid_pn)
    - mempool_destroy(adapter->pool.gid_pn);
    + mempool_destroy(adapter->pool.erp_req);
    + mempool_destroy(adapter->pool.scsi_req);
    + mempool_destroy(adapter->pool.scsi_abort);
    + mempool_destroy(adapter->pool.qtcb_pool);
    + mempool_destroy(adapter->pool.status_read_req);
    + mempool_destroy(adapter->pool.sr_data);
    + mempool_destroy(adapter->pool.gid_pn);
    }

    /**
    \
     
     \ /
      Last update: 2018-12-02 22:17    [W:3.413 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site