Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 19 Dec 2018 17:58:53 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled |
| |
On Wed, 19 Dec 2018, Josh Poimboeuf wrote:
> This option only makes sense for source-based patch generation, so isn't > it a bit premature to make this change without proper source-based patch > tooling?
The reality is though that before the full-fledged patch tooling exists, people are actually already writing livepatches by hand, so this option is useful for them.
> Also the commit message needs an analysis of the performance impacts.
Agreed. Especially as it's expected (*) to be completely in the noise particularly for the kernel, it'd be good to have that documented in the changelog.
(*) actually measured already for some subset of the IPA optimizations
Thanks,
-- Jiri Kosina SUSE Labs
| ![\](/images/icornerr.gif) |