Messages in this thread | | | Date | Wed, 19 Dec 2018 13:37:33 +0100 | From | Greg KH <> | Subject | Re: [PATCH] hpet: Fix missing '=' character in the __setup() code of hpet_mmap_enable. |
| |
On Wed, Dec 19, 2018 at 05:34:32PM +0530, Buland Singh wrote: > On 12/19/18 3:16 PM, Greg KH wrote: > > On Wed, Dec 19, 2018 at 02:55:02PM +0530, Buland Singh wrote: > > > The kernel command parameter 'hpet_mmap' never takes effect due to missing > > > '=' character in the __setup() code of hpet_mmap_enable and the memory map > > > of the HPET registers never get expose to userspace. > > > > > > Signed-off-by: Buland Singh <bsingh@redhat.com> > > > --- > > > drivers/char/hpet.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c > > > index 4a22b4b41aef..9bffcd37cc7b 100644 > > > --- a/drivers/char/hpet.c > > > +++ b/drivers/char/hpet.c > > > @@ -377,7 +377,7 @@ static __init int hpet_mmap_enable(char *str) > > > pr_info("HPET mmap %s\n", hpet_mmap_enabled ? "enabled" : "disabled"); > > > return 1; > > > } > > > -__setup("hpet_mmap", hpet_mmap_enable); > > > +__setup("hpet_mmap=", hpet_mmap_enable); > > > > What commit caused this bug? Should this go to the stable kernel trees? > > Hello Greg, > > The commit id is 3d035f58. The bug is there since the initial patch which > introduced the kernel parameter 'hpet_mmap'. The fix should go to the > stable kernel trees.
Great, can you resend it with all of this information (a fixes: and cc: stable tag?)
thanks,
greg k-h
| |